fix: merge address info when aliasing entries to handle out-of-order DNS records#151
Open
Yanhu007 wants to merge 1 commit intohashicorp:mainfrom
Open
fix: merge address info when aliasing entries to handle out-of-order DNS records#151Yanhu007 wants to merge 1 commit intohashicorp:mainfrom
Yanhu007 wants to merge 1 commit intohashicorp:mainfrom
Conversation
When A/AAAA records arrive before SRV records, the alias function overwrites the existing entry (which has the IP address) with the SRV's entry (which has the port), losing the address information. This causes the service entry to never become complete, and the service is not discovered. Now when the alias destination already has an entry with address information, merge it into the source entry before overwriting. This handles out-of-order DNS record delivery, as seen with devices like the Alfen EV Charger. Fixes hashicorp#145
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
1 similar comment
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145
Problem
When DNS records arrive in certain orders (A/AAAA before SRV), the
aliasfunction overwrites an existing entry that already has an IP address with the SRV entry that only has port/host info. The IP address is lost, and the entry never becomes complete.Example failure sequence:
device.local.→ creates entry with IPdevice._service._tcp.local.with targetdevice.local.→alias()overwrites the A-record entry, losing the IPThis was reported with Alfen EV Chargers but affects any device that sends A/AAAA records before SRV records.
Fix
In
alias(), when the destination key already has an entry with address information, merge the addresses into the source entry before overwriting the map entry.Testing
All existing tests pass.