2193 bug assignment dropdown on agent detail page loads too much#715
Open
correct-horse-battery-bench wants to merge 7 commits into
Open
Conversation
…regates have to explicitely be requested
…arrowed builder type The generic RequestParamBuilder (this branch) narrows builder locals to RequestParamBuilder<'pretaskFiles', never>, but master's applyMaskImportFilter was typed to the wide IParamBuilder, so reassigning through it produced TS2739 in the merge build. Make the helper generic (<B extends IParamBuilder>(params: B): B), matching applyFilterWithPaginationReset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires server branch: aggregation-improvements https://github.com/hashtopolis/server/tree/aggregation-improvements
On systems with large number of chunks we have the problem that certain pages do not load due to server returning data that is not needed or that in certain pages (edit agent) the client fetches all chunks and tries to calculate things client side that should probably be moved to the server.
Therefore the server changes the contract and aggregated fields have to be added explicitely otherwise they are not returned.
This means that on usages where we access these aggregated fields we have to explicitely pass them as request param for example "aggregate[task]=dispatched.
In order to catch errors where we forget to request these aggregates but they are still used improve typing that similar to include fields if the aggregate field is passed then it is in the type returned by the deserializer. If the aggregate is not included then the return type does NOT include the field.
Therefore wherever we use these aggregated fields after this change there would be a type error and the params can be amended.
Remove client side crackingTime calcualtion by fetching all chunks -> server branch adds aggregated field crackingTime to agent which is requested
explicitely pass everywhere aggregated fields wherever we require them
improve typing of request builder and serializer, makes it a bit more complicated but enforces passing the correct values -> probably worth a discussion how we want to do this in the future
Server Issue: hashtopolis/server#2193