Fix Zod validation error for notifications not tied to an object (#2224)#719
Open
correct-horse-battery-bench wants to merge 2 commits into
Conversation
Notifications that are not directly tied to an object (e.g. a global agentError shown as "N/A" under "applied to") carry a null or absent objectId. The generated notification-setting schema required a non-null integer objectId, so the serializer's validateBody() logged a large ZodError to the console when listing such notifications. Drop objectId from the required set and widen its type to allow null in openapi.json; the codegen then produces objectId: z.int().nullish() and objectId?: number | null. Update JNotification and the datasource cast accordingly, and add a schema-level regression spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some notifications are not tied to an object, fix typing and relax zod vallidation schemas in this case
Issue: hashtopolis/server#2224