Move addFields to ParseUtils - #10394
Closed
9999years wants to merge 2 commits into
Closed
Conversation
This helper function was challenging to understand, so I added an explicit type signature and documentation comments to it.
`addFields` should be in `ParseUtils` with the rest of the field helpers.
This was referenced Sep 27, 2024
geekosaur
approved these changes
Sep 28, 2024
9999years
marked this pull request as ready for review
September 28, 2024 01:17
Collaborator
|
This patch doesn't make sense without a patch which also uses |
Collaborator
Author
|
@mpickering I felt that keeping independent changes in independent PRs makes each PR smaller and easier to review, but I've combined this change into #10393 if you prefer that. |
Collaborator
|
I prefer to keep changes which only make logical sense together in a single atomic patch. There is always the possibility in open source that promised patches never end up arriving, at which point landing this patch creates more work as it needs to be reverted or immediately becomes legacy code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off of #10292.