Fix HaddockKeepTmpsCustom test for merge skew - #10424
Merged
Merged
Conversation
ulysses4ever
approved these changes
Oct 4, 2024
ulysses4ever
left a comment
ulysses4ever
left a comment
Collaborator
There was a problem hiding this comment.
Will need to be fast-tracked if effective.
geekosaur
approved these changes
Oct 4, 2024
9999years
marked this pull request as ready for review
October 4, 2024 23:52
Collaborator
Author
|
I'm off for the weekend, but hopefully this passes CI. |
ulysses4ever
added
the
merge delay passed
mergify
Bot
added
the
ready and waiting
The `HaddockKeepTmpsCustom` test added in haskell#10392 skewed against haskell#10366, which changes where temporary files are written. We can work around this by setting `$TMPDIR` and `$TEMP` while running tests, so that temporary files are written to the test's temporary directory rather than the system one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HaddockKeepTmpsCustomtest added in #10392 skewed against #10366, which changes where temporary files are written.We can work around this by setting
$TMPDIRand$TEMPwhile running tests, so that temporary files are written to the test's temporary directory rather than the system one.