Skip to content

Fix whitespace issue in changelog - #10642

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
alt-romes:wip/romes/cabal-fix-whitespace
Dec 16, 2024
Merged

Fix whitespace issue in changelog#10642
mergify[bot] merged 1 commit into
haskell:masterfrom
alt-romes:wip/romes/cabal-fix-whitespace

Conversation

@alt-romes

@alt-romes alt-romes commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@alt-romes

alt-romes commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator Author

@geekosaur here it is

@alt-romes alt-romes mentioned this pull request Dec 16, 2024
Open
6 tasks
geekosaur
geekosaur requested changes Dec 16, 2024
View reviewed changes

@geekosaur geekosaur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a PR template, please.

@alt-romes

alt-romes commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator Author

Added

@geekosaur

geekosaur commented Dec 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

High priority because in some sense master is currently broken / doesn't pass CI since changelog.d was added to the whitespace check, and in particular other PRs will block on this until master is updated and they are rebased. See #10639 (comment).

@Mikolaj

Mikolaj commented Dec 16, 2024

Copy link
Copy Markdown
Member

If nobody objects I will expedite the merge in a moment, as @geekosaur suggests.

@geekosaur

geekosaur commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator

Just set merge me, Mergify already knows about priority: high.

@alt-romes alt-romes added the merge me Tell Mergify Bot to merge label Dec 16, 2024
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Dec 16, 2024
@mergify
mergify Bot merged commit 3727226 into haskell:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes
@philderbeast philderbeast philderbeast approved these changes
@geekosaur geekosaur geekosaur approved these changes

Assignees

No one assigned

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alt-romes @geekosaur @Mikolaj @philderbeast