Fix project packages glob parsing - #12172
Open
philderbeast wants to merge 8 commits into
Open
Conversation
philderbeast
force-pushed
the
test/parse-packages-glob
branch
from
July 28, 2026 19:45
86f5fcc to
6fb47bd
Compare
zlonast
reviewed
Jul 30, 2026
philderbeast
force-pushed
the
test/parse-packages-glob
branch
2 times, most recently
from
August 2, 2026 01:03
5048f32 to
6b3a2e2
Compare
Member
|
Where are the globs handled in the code? I only see the curly braces syntax, which is only the half of the example in the issue. |
philderbeast
force-pushed
the
test/parse-packages-glob
branch
from
August 11, 2026 14:13
6b3a2e2 to
f3c26eb
Compare
philderbeast
marked this pull request as draft
August 13, 2026 17:11
philderbeast
force-pushed
the
test/parse-packages-glob
branch
2 times, most recently
from
August 13, 2026 17:22
2851518 to
f01b796
Compare
philderbeast
marked this pull request as ready for review
August 13, 2026 17:22
philderbeast
commented
Aug 13, 2026
Comment on lines
+69
to
+70
| -- >>> getPackageLocationTokens <$> (simpleParsec "*/*.cabal ../{foo,bar}/" :: Maybe PackageLocationTokens) | ||
| -- Just ["*/*.cabal","../{foo,bar}/"] |
Collaborator
Author
There was a problem hiding this comment.
Where are the globs handled in the code? I only see the curly braces syntax, which is only the half of the example in the issue.
@Mikolaj as well as the parser tests, I've added a doctest example here, same as the one in the users guide.
philderbeast
force-pushed
the
test/parse-packages-glob
branch
from
August 13, 2026 19:44
f01b796 to
0a1d051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing test for #12171 and its fix.
I'll squash commits before applying the merge label if this pull request is approved.
significance: significantin the changelog file.