Update CI to test with GHC 9.14 #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failures are due to haskell-CI/haskell-ci#789 IMO it's not worth trying to fix the warning for containers-tests. It defines some dependency groups which seem harmless and it would be a pain to inline them into each test suite. containers/containers-tests/containers-tests.cabal Lines 36 to 63 in 32ed12a |
meooow25
force-pushed
the
ci-9.14
branch
3 times, most recently
from
66fc913 to
3648305
Compare
Contributor
Author
|
Now it's haskell-CI/haskell-ci#790 |
Contributor
Author
|
Okay it's all green now. |
Contributor
|
Looking more closely, I see that most of your pattern match fixes are substantial clarity improvements as well. I just happened to see the least valuable one first. |
* Update compiler versions * Update deepseq bounds in containers-tests to match that in containers * haskell-ci adds some warnings now, ignore unused-packages and fix incomplete-patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.