Add support for post qualified import formatting (more cases)#372
Merged
lukasz-golebiewski merged 4 commits intohaskell:mainfrom Jul 16, 2021
Merged
Conversation
Adds an option to use post qualified module imports. Related to haskell#284 Resolves haskell#334
akrmn
changed the title
lukasz-golebiewski
approved these changes
Jul 16, 2021
Member
lukasz-golebiewski
left a comment
lukasz-golebiewski
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Contributor
|
Could you please release this change? |
Member
|
@jaspervdj could you? |
Member
|
Released |
Contributor
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work started by @jhmcstanton. I added a few more test cases, and adapted the logic to support them. I originally submitted this as a PR to @jhmcstanton's branch, but I haven't got a reply, so I thought submitting a PR including their commit might be simpler.
Adds an option to use post qualified module imports.
Related to #284
Resolves #334
Improves on #335
Let me know if any more tests or changes are needed.