Rename constructors and related parser strings of LongListAlign#467
Open
sorki wants to merge 1 commit intohaskell:mainfrom
Open
Rename constructors and related parser strings of LongListAlign#467sorki wants to merge 1 commit intohaskell:mainfrom
sorki wants to merge 1 commit intohaskell:mainfrom
Conversation
The documentation of these doesn't quite reflect the implementation and it seems to cause some confusion. This patch tries to address it by renaming `LongListAlign` constructors to better reflect what they do and fix their documentation in `stylish-haskell.yaml`. There is no change in functionality but it introduces a breaking change for users using the Haskell interface. It also adds a (lousy) concept of config option deprecation in form of documenting the deprecated variants in favor of new names. Related to haskell#462
This was referenced Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of these doesn't quite reflect the implementation and it seems to cause some confusion.
This patch tries to address it by renaming
LongListAlignconstructors to better reflect what they do and fix their documentation instylish-haskell.yaml.There is no change in functionality but it introduces a breaking change for users using the Haskell interface. It also adds a (lousy) concept of config option deprecation in form of documenting the deprecated variants in favor of new names.
Related to #462