CH32X035 port#3703
Open
rhgndf wants to merge 4 commits into
Open
Conversation
Collaborator
Seems like v103, do you have board to test with ? |
|
| target | .text | .rodata | .data | .bss | total | % diff |
|---|---|---|---|---|---|---|
| ch32v103c_bluepill/dynamic_configuration | — | — | — | 4,104 → 3,976 (-128) | 14,392 → 14,264 (-128) | -0.9% |
| ch32v103c_bluepill/dfu_runtime | 8,556 → 8,588 (+32) | — | — | 2,880 → 2,752 (-128) | 13,900 → 13,804 (-96) | -0.7% |
| ch32v103c_bluepill/hid_generic_inout | 9,528 → 9,560 (+32) | — | — | 3,084 → 2,956 (-128) | 15,080 → 14,984 (-96) | -0.6% |
| ch32v103c_bluepill/hid_boot_interface | 10,388 → 10,416 (+28) | — | — | 2,960 → 2,832 (-128) | 15,812 → 15,712 (-100) | -0.6% |
| ch32v103c_bluepill/hid_composite | 10,612 → 10,640 (+28) | — | — | 2,948 → 2,820 (-128) | 16,028 → 15,928 (-100) | -0.6% |
| ch32v103c_bluepill/hid_multiple_interface | 10,368 → 10,400 (+32) | — | — | 2,960 → 2,832 (-128) | 15,792 → 15,696 (-96) | -0.6% |
| ch32v103c_bluepill/midi_test | 10,720 → 10,752 (+32) | — | — | 3,208 → 3,080 (-128) | 16,392 → 16,296 (-96) | -0.6% |
| ch32v103c_bluepill/cdc_dual_ports | 11,736 → 11,764 (+28) | — | — | 3,552 → 3,424 (-128) | 17,752 → 17,652 (-100) | -0.6% |
| ch32v103c_bluepill/printer_to_cdc | 11,908 → 11,936 (+28) | — | — | 3,496 → 3,368 (-128) | 17,852 → 17,752 (-100) | -0.6% |
| ch32v103c_bluepill/webusb_serial | 12,248 → 12,276 (+28) | — | — | 3,508 → 3,380 (-128) | 18,320 → 18,220 (-100) | -0.5% |
Contributor
Author
I don't have the board unfortunately. I may take a look if I need a 5V capable mcu though (although py32f07x is also 5V capable but has additional DACs unlike v103) |
Contributor
Author
Got claude to analyze the discrepency, here's the output verbatim: |
hathach
added a commit
to alt-0191/tinyusb
that referenced
this pull request
Jun 19, 2026
dcd_edpt_xfer() re-enabled the USB interrupt before update_in() / ep_rx_set_response(), which read-modify-write the (combined) EP control register. On CH58x the ISR RMWs that same register to flip the manual data toggle, so a transfer interrupt landing mid-RMW could drop the toggle flip and desync the endpoint. Move dcd_int_enable() to after the arming so the whole sequence is atomic w.r.t. the ISR (matching the CH32X035 port hathach#3703). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
|
thank you, after #3515, this should be relatively easy. I have the CH32X035 board but run out of wlinke debugger (attached to hil rig). will get this mcu ported when it got on my desk |
Contributor
Author
|
I also simplified the comments, since I found a hallucination involving X035.
|
Contributor
Author
|
According to the manuals, it says only EP4 needs manual toggling, maybe manual toggle should only be enabled for EP4? |
Hardware-in-the-loop (HIL) Test Reporthfp.json✅ 52 passed · ❌ 0 failed · ⚪ 0 skipped · blank not run
tinyusb.json✅ 337 passed · ❌ 2 failed · ⚪ 11 skipped · blank not run
|
Collaborator
|
Hi, I see many comment changes, please verify are they intended. |
Contributor
Author
|
Yes they are intended, since there was a hallucination about the x035 and I was concerned there are more, so I got my agent to shrink all of them so they can be verified easily |
Collaborator
|
Many comments are from Ha Thach like
They shoudn't be removed. |
rhgndf
force-pushed
the
ch32x035
branch
5 times, most recently
from
7f1322b to
d2b4873
Compare
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in size
Changes <1% in sizeNo entries. No changes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for both CH32X035 and CH32X033.
I'm also evaluating this MCU due to it being low cost and have USB.
CH32X035 has both TX and RX CTRL bits in the same byte, so there are changes to how these registers are written in the dcd.
If the current approach isn't satisfactory, there are some alternatives:
EP4 special handling:
This is a bit confusing, and Codex/Claude has been very helpful to get that part working. In short: no DMA and no auto-toggle, so some special handling has to be built in.
EP3 no special large buffer
The code has some existing handling for large EP3 buffer, but as far as I can tell that functionality doesn't exist in ch32x035, should I #if that out for this port?
Related: adafruit/Adafruit_TinyUSB_Arduino#486