Compress kafka messages and fix exception in findAll#2
Merged
ArtyomSavchenko merged 6 commits intomainfrom Nov 19, 2025
Merged
Conversation
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Kafka message compression using GZIP and fixes a null pointer exception in the FindSecurityMiddleware's findAll method.
- Adds GZIP compression to Kafka producers to reduce network bandwidth
- Fixes exception when options parameter is null in FindSecurityMiddleware.findAll
- Bumps versions for both @hcengineering/middleware (0.7.19 → 0.7.20) and @hcengineering/kafka (0.7.16 → 0.7.17)
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/kafka/src/index.ts | Adds CompressionTypes import and enables GZIP compression for Kafka producer |
| packages/kafka/package.json | Version bump to 0.7.17 |
| packages/kafka/CHANGELOG.md | Documents compression feature |
| packages/kafka/CHANGELOG.json | Structured changelog entry for compression |
| packages/middleware/src/findSecurity.ts | Changes null check from !== undefined to != null to prevent NPE on destructuring |
| packages/middleware/package.json | Version bump to 0.7.20 |
| packages/middleware/CHANGELOG.md | Documents findAll fix |
| packages/middleware/CHANGELOG.json | Structured changelog entry for fix |
| common/changes/@hcengineering/middleware/fix-formatting_2025-11-12-14-59.json | Removes change file after incorporation into changelog |
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Signed-off-by: Artem Savchenko <armisav@gmail.com>
GeneralGDA
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.