Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 79e51ab. Configure here.
| """Stop sessions this client bridged; a local client also stops its runtime once no other client uses it.""" | ||
| try: | ||
| if self._sessions is not None: | ||
| self._sessions.close() |
There was a problem hiding this comment.
Close calls missing session methods
Medium Severity
close and aclose invoke self._sessions.close() and self._sessions.aclose(), but neither LocalSessionsClient nor the generated sessions clients define those methods. After sessions are initialized, the new context-manager cleanup raises AttributeError instead of stopping bridged sessions.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 79e51ab. Configure here.
Collaborator
Author
|
Folded into #233. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Auto-generated from the upstream codegen home.
Version:
1.0.17(patch; every sync bumps +0.0.1)Upstream: agent_platform@e525a14
Note
Low Risk
Additive credential resolution for client construction; reads a local config file but does not change how keys are sent on requests.
Overview
Bumps the Python SDK to v1.0.17 (package version, lockfile, and HTTP client metadata).
Client/AsyncClientnow fill in a missingapi_keyautomatically: explicit argument, thenHAI_API_KEY, then the valuehai loginwrote to the config.env($XDG_CONFIG_HOME/hai/.envor~/.config/hai/.env). If nothing is found, construction fails with anApiErrorthat mentions passingapi_key, setting the env var, or runninghai login.Reviewed by Cursor Bugbot for commit 8722418. Bugbot is set up for automated code reviews on this repo. Configure here.