This repository was archived by the owner on Jul 16, 2021. It is now read-only.
Don't return error when repos have no chart#633
Open
FengyunPan2 wants to merge 1 commit intohelm:masterfrom
Open
Don't return error when repos have no chart#633FengyunPan2 wants to merge 1 commit intohelm:masterfrom
FengyunPan2 wants to merge 1 commit intohelm:masterfrom
Conversation
FengyunPan2
force-pushed
the
not-err
branch
2 times, most recently
from
147a1dd to
86b6e66
Compare
Fix helm#632 I build a chartmuseum service which has no charts, then add the chartmuseum repo into kubeapps. But I get a 'error' pod, that is unfriendly. I think it is better to add log for it. Signed-off-by: FengyunPan2 <pan_feng_yun@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #632
I build a chartmuseum service which has no charts, then add the
chartmuseum repo into kubeapps. But I get a 'error' pod, that is
unfriendly. I think it is better to add log for it.
Related to: #604
cc @prydonius