Skip to content

fix: add missing type for GetSellerListResponse#207

Merged
dantio merged 1 commit intohendt:masterfrom
jingerpie:master
Apr 4, 2026
Merged

fix: add missing type for GetSellerListResponse#207
dantio merged 1 commit intohendt:masterfrom
jingerpie:master

Conversation

@jingerpie
Copy link
Copy Markdown
Contributor

Summary

  • Fix Item type from single object to Array<{...}> to correctly represent multiple items
  • Add missing fields: HasMoreItems, PositiveFeedbackPercent, LiveAuctionAuthorized, MerchandizingPref, MotorsDealer
  • Mark optional fields that may not always be present: FeedbackRatingStar, SellerLevel, UserAnonymized
  • Remove redundant StandardOutputFields properties duplicated in 3 response interfaces

Test plan

  • Build passes (npm run build)
  • Verify GetSellerList API responses match updated types
  • Run existing tests (npm run test)

@jingerpie
Copy link
Copy Markdown
Contributor Author

Hi, few month ago, I added these types, I notice one of them has a missing type. Please merge this, thank you so much!

@jingerpie
Copy link
Copy Markdown
Contributor Author

@dantio Hi I notice this isnt merge, any problem? Also a reminder that this project uses axios, there is a recent critical issues in regard to it. Are you considering to set version limit or perhaps use fecth?

@dantio dantio merged commit 60a13d4 into hendt:master Apr 4, 2026
1 check passed
@dantio
Copy link
Copy Markdown
Collaborator

dantio commented Apr 4, 2026

Are you considering to set version limit or perhaps use fecth?
Axios is locked to 1.13.5 in package-lock. I do not use any CI that automatically release the lib.

Yes, I plan to migrate to fetch (probably with ky)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants