Deterministic generation and other ideas#33
Open
irigarae wants to merge 29 commits intohenryw374:masterfrom
Open
Deterministic generation and other ideas#33irigarae wants to merge 29 commits intohenryw374:masterfrom
irigarae wants to merge 29 commits intohenryw374:masterfrom
Conversation
b63fe34 to
6c1ca99
Compare
a3b3f2d to
b5b2c75
Compare
b5b2c75 to
9179960
Compare
9179960 to
b660117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @henryw374, as mentioned on #31 (comment) while looking how to add the constructor I had some ideas and here's a PR showing them.
I don't want to get this PR merged necessarily, just to leave the code here for you, in case you want to cherry-pick some or it gives you other ideas on what would be nice for the codebase.
The commits are atomic, followed with some generation, so you can take a look at them individually and see the changes.
gensym)defn^{:line 89, :column 16}meta from output.clj.andwhen single conditionthisat method level instead ofletcharlikeintletlocal declarationjava.time.temporal.TemporalField/1class syntaxAs I say, I use this as a way to bring many ideas all at once, maybe unrelated, if you like some of them I could do individual PRs, or you can just do whatever :)
Thanks for the library.