Skip to content

CASL-1738_Violations_PostProcessing#568

Merged
rlakde merged 6 commits intov2from
CASL-1738_MOM10_Violations
Mar 20, 2026
Merged

CASL-1738_Violations_PostProcessing#568
rlakde merged 6 commits intov2from
CASL-1738_MOM10_Violations

Conversation

@rlakde
Copy link
Copy Markdown
Member

@rlakde rlakde commented Mar 18, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Code Coverage

Overall Project 42.97% -0.03% 🍏
Files changed 62.32% 🍏

Module Coverage
here-naksha-app-service 72.1% 🍏
here-naksha-lib-handlers 35.61% -0.64% 🍏
Files
Module File Coverage
here-naksha-app-service AbstractApiTask.java 86.81% 🍏
here-naksha-lib-handlers MockValidationHandler.java 0% -11.98% 🍏

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Code Coverage

Overall Project 42.98% -0.03% 🍏
Files changed 64.38% 🍏

Module Coverage
here-naksha-app-service 72.1% 🍏
here-naksha-lib-handlers 35.61% -0.64% 🍏
here-naksha-lib-core 32.8% 🍏
Files
Module File Coverage
here-naksha-app-service AbstractApiTask.java 86.81% 🍏
here-naksha-lib-handlers MockValidationHandler.java 0% -11.98% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

hirenkp2000
hirenkp2000 requested changes Mar 18, 2026
View reviewed changes
Comment thread ...app-service/src/test/java/com/here/naksha/app/service/Mom10ViolationsPostProcessingTest.java Outdated
Comment thread ...urces/unit_test_data/Mom10ValDryRun/testViolationsPostProcessingResult/mom10_violations.json Outdated
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Code Coverage

Overall Project 42.98% -0.03% 🍏
Files changed 64.38% 🍏

Module Coverage
here-naksha-app-service 72.1% 🍏
here-naksha-lib-handlers 35.61% -0.64% 🍏
here-naksha-lib-core 32.8% 🍏
Files
Module File Coverage
here-naksha-app-service AbstractApiTask.java 86.81% 🍏
here-naksha-lib-handlers MockValidationHandler.java 0% -11.98% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

hirenkp2000
hirenkp2000 approved these changes Mar 19, 2026
View reviewed changes
Comment thread ...app-service/src/test/java/com/here/naksha/app/service/Mom10ViolationsPostProcessingTest.java Outdated
@hirenkp2000 hirenkp2000 self-requested a review March 19, 2026 04:58
hirenkp2000
hirenkp2000 requested changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hirenkp2000 hirenkp2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good once pending comment is addressed

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Code Coverage

Overall Project 42.96% -0.03% 🍏
Files changed 64.38% 🍏

Module Coverage
here-naksha-app-service 72.1% 🍏
here-naksha-lib-handlers 35.61% -0.64% 🍏
here-naksha-lib-core 32.79% 🍏
Files
Module File Coverage
here-naksha-app-service AbstractApiTask.java 86.81% 🍏
here-naksha-lib-handlers MockValidationHandler.java 0% -11.98% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

hirenkp2000
hirenkp2000 requested changes Mar 20, 2026
View reviewed changes
Comment thread ...ksha-app-service/src/test/java/com/here/naksha/app/common/assertions/ResponseAssertions.java Outdated
Comment thread ...ksha-app-service/src/test/java/com/here/naksha/app/common/assertions/ResponseAssertions.java Outdated
Comment thread ...ksha-app-service/src/test/java/com/here/naksha/app/common/assertions/ResponseAssertions.java Outdated
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Code Coverage

Overall Project 42.98% -0.03% 🍏
Files changed 64.38% 🍏

Module Coverage
here-naksha-app-service 72.1% 🍏
here-naksha-lib-handlers 35.61% -0.64% 🍏
here-naksha-lib-core 32.8% 🍏
Files
Module File Coverage
here-naksha-app-service AbstractApiTask.java 86.81% 🍏
here-naksha-lib-handlers MockValidationHandler.java 0% -11.98% 🍏
here-naksha-lib-core NakshaVersion.java 42.31% 🍏

@rlakde rlakde merged commit 9c0643a into v2 Mar 20, 2026
3 checks passed
@rlakde rlakde deleted the CASL-1738_MOM10_Violations branch March 20, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirenkp2000 hirenkp2000 hirenkp2000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rlakde @hirenkp2000