fix(server): missing firewalls in describe - #1482
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1482 +/- ##
==========================================
- Coverage 73.08% 72.81% -0.28%
==========================================
Files 301 302 +1
Lines 11097 11177 +80
==========================================
+ Hits 8110 8138 +28
- Misses 2090 2141 +51
- Partials 897 898 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
reviewed
Sep 10, 2026
jooola
approved these changes
Sep 14, 2026
jooola
reviewed
Sep 14, 2026
Comment on lines
+121
to
+123
| Firewalls: | ||
| No Firewalls | ||
|
|
Member
There was a problem hiding this comment.
Should we also test with some firewall attached?
jooola
pushed a commit
that referenced
this pull request
Sep 14, 2026
<!-- section-start changelog --> ### Features - print deprecated Load Balancer Type information (#1461) ([22a60bc](22a60bc)) - add api command (#1457) ([bd9f704](bd9f704)) - **image**: print deprecated Image information (#1485) ([c7badc0](c7badc0)) ### Bug Fixes - **server**: missing firewalls in describe (#1482) ([93f8381](93f8381)) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1481