fix: provision volumes in the correct location with enableProvidedByTopology#1434
Open
lukasmetzner wants to merge 2 commits into
Open
fix: provision volumes in the correct location with enableProvidedByTopology#1434lukasmetzner wants to merge 2 commits into
lukasmetzner wants to merge 2 commits into
Conversation
…opology When enableProvidedByTopology is enabled, the generated StorageClass only carries the `instance.hetzner.cloud/provided-by` topology segment. Without `--strict-topology` the external-provisioner uses allowedTopologies as the requisite topology and drops the selected node's `csi.hetzner.cloud/location`, so the controller fell back to the controller pod's location and provisioned volumes in the wrong place, leaving pods unschedulable. Fixes #1428
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 75.13% 73.91% -1.22%
==========================================
Files 17 17
Lines 1520 1526 +6
==========================================
- Hits 1142 1128 -14
- Misses 293 309 +16
- Partials 85 89 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukasmetzner
marked this pull request as ready for review
July 17, 2026 09:25
jooola
approved these changes
Jul 17, 2026
jooola
left a comment
jooola
left a comment
Member
There was a problem hiding this comment.
I cannot really vet the behavior change in the code, but otherwise looks good.
jooola
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enableProvidedByTopology is enabled, the generated StorageClass only
carries the
instance.hetzner.cloud/provided-bytopology segment. Without--strict-topologythe external-provisioner uses allowedTopologies as therequisite topology and drops the selected node's
csi.hetzner.cloud/location,so the controller fell back to the controller pod's location and provisioned
volumes in the wrong place, leaving pods unschedulable.
Fixes #1428