fix(ui): frame the diff as the pane's surface and add a wallpaper tinting option (#275, #276) - #282
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hewigovens
force-pushed
the
polish-tinting
branch
4 times, most recently
from
September 18, 2026 10:13
c5c3a3f to
b0c5e79
Compare
…ting option (#275, #276) The diff no longer sits in a rounded, inset card: text diffs, previews and placeholders run to the pane edges while the diff header and its banners keep the same 18 pt inset as the metadata above, and Edit Diff moves from the description row into the diff header next to Unified/Split with its action, keyboard stop, help text and accessibility identifier intact; the neighbouring file editor button is titled Edit File, and below 600 pt the header controls drop their titles and keep their symbols so the file name is never squeezed out (#275). Dark-mode wallpaper tinting stays on by default because it is what macOS does to every window, and a new Appearance setting with the system's own wording, Tint window background with wallpaper color, turns it off by painting the window content with the system text background so the sidebar, file list and diff share one neutral surface on any desktop (#276); the file lists hide their own scroll background only while tinting is off. The section identifier now lives on the header's file name instead of propagating from the section root, which had been overwriting every child's identifier; the image resize scene finds its divider by label.
hewigovens
force-pushed
the
polish-tinting
branch
from
September 18, 2026 11:26
b0c5e79 to
f599321
Compare
hewigovens
changed the title
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff no longer sits in a rounded, inset card: text diffs, previews and placeholders run to the pane edges while the diff header and its banners keep the same 18 pt inset as the metadata above, and Edit Diff moves from the description row into the diff header next to Unified/Split with its action, keyboard stop, help text and accessibility identifier intact; the neighbouring file editor button is titled Edit File, and below 600 pt the header controls drop their titles and keep their symbols so the file name is never squeezed out (#275). Dark-mode wallpaper tinting stays on by default because it is what macOS does to every window, and a new Appearance setting with the system's own wording, Tint window background with wallpaper color, turns it off by painting the window content with the system text background so the sidebar, file list and diff share one neutral surface on any desktop (#276); the file lists hide their own scroll background only while tinting is off.
Closes #275. Closes #276. Part of #270.
The section identifier now lives on the header's file name instead of propagating from the section root, which had been overwriting every child's identifier; the image resize scene finds its divider by label. Below 600 pt of header width the controls drop their titles and keep their symbols.
Before / after
Same fixture repo, same selection, revset bar shown, 2x. Before is current main.
Light
Before
After
Dark
Before
After
Narrow window (1024 pt)
Below 600 pt of header width the controls keep their symbols and drop their titles.
Wallpaper tinting turned off (dark)
Settings