test: drop lodash dependency and use a local sortBy helper instead - #294
Open
yoshinorin wants to merge 1 commit into
Open
test: drop lodash dependency and use a local sortBy helper instead#294yoshinorin wants to merge 1 commit into
lodash dependency and use a local sortBy helper instead#294yoshinorin wants to merge 1 commit into
Conversation
D-Sketon
approved these changes
Aug 13, 2026
SukkaW
requested changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Add test cases for the changes.Description
Removed
lodashfromdevDependencies:lodashwas only used forsortBy(data, '_id')in two test files (test/scripts/query.ts,test/scripts/model.ts) — pulling in the whole package just for a single-key sort is overkill.sortByhelper intest/helpers.tsand pointed both test files at it instead.Additional information
see: You-Dont-Need-Lodash-Underscore