basicLit: format numbers from the reflect.Value's kind#28
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Closes hexops#11. fmt.Sprint(v) on a named numeric type like time.Duration calls the type's Stringer (returns '1h0m0s'), so the produced AST contained an invalid Go literal and gofumpt then errored with 'missing ',' in argument list'. Format INT/FLOAT/UINT from the reflect.Value's kind so the literal is always valid Go syntax. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
fmt.Sprint(v)on a named numeric type liketime.Durationcalls the type'sStringer("1h0m0s"), so the produced AST contained an invalid Go literal and gofumpt then errored with "missing ',' in argument list". Format INT / FLOAT / UINT from thereflect.Value's kind so the literal is always valid Go syntax.