DefaultPackagePathToName: fall back to a path-based guess when go isn't available#29
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
…'t available Closes hexops#18. packages.Load shells out to the go binary, so in environments where that's absent (WebAssembly, the Go Playground) String() returned 'go command required, not found'. When packages.Load fails or returns no name, derive the package name from the last non-version segment of the import path. That's not always the real name but it's good enough to render literals without forcing every caller to set a custom PackagePathToName. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
packages.Loadshells out to thegobinary, so in environments where that's absent (WebAssembly, the Go Playground)String()returned go command required, not found. Whenpackages.Loadfails or returns no name, derive the package name from the last non-version segment of the import path. That isn't always the real name but it's good enough to render literals without forcing every caller to set a customPackagePathToName.