Skip to content

fix: improve parseAs handling and cleanup lint issues#3859

Open
aartisonigra wants to merge 9 commits into
hey-api:mainfrom
aartisonigra:fix/parseas-type-safe
Open

fix: improve parseAs handling and cleanup lint issues#3859
aartisonigra wants to merge 9 commits into
hey-api:mainfrom
aartisonigra:fix/parseas-type-safe

Conversation

@aartisonigra
Copy link
Copy Markdown

Summary

This PR improves getParseAs handling and fixes related type safety issues.

Changes

  • improved getParseAs() response parsing logic
  • cleaned up unused variable warnings
  • fixed empty catch block lint issue
  • migrated example scripts from require() to ES module imports
  • improved request/response handling consistency
  • fixed lint and formatting issues

Testing

  • pnpm lint:fix
  • pnpm build
  • pnpm test

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 9, 2026

🦋 Changeset detected

Latest commit: b684dac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/custom-client Patch
@test/openapi-ts Patch
@hey-api/shared Patch
@hey-api/vite-plugin Patch
@hey-api/openapi-python Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026

@aartisonigra is attempting to deploy a commit to the Hey API Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 9, 2026
@aartisonigra
Copy link
Copy Markdown
Author

Can you please review my PR?

@mrlubos
Copy link
Copy Markdown
Member

mrlubos commented May 24, 2026

@aartisonigra please make sure CI checks pass!

Copy link
Copy Markdown
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure CI checks pass!

@aartisonigra
Copy link
Copy Markdown
Author

@mrlubos ,The build output is successfully generated and all dist artifacts are present. However, tsdown fails in a post-build “pack” step with a TypeError (reading 'filename'), which appears to be a tooling issue rather than a change introduced in this PR.

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants