feat(sdk,studio): stage 7 step 3a — persistPath + SDK session reload-on-change#1523
Closed
vanceingalls wants to merge 12 commits into
Closed
Conversation
…lding SDK cutover is now unconditionally enabled. Removes STUDIO_SDK_SHADOW_ENABLED and STUDIO_SDK_CUTOVER_ENABLED feature flags, deletes sdkShadow.ts and its tests, moves patchOpsToSdkEditOps into sdkCutover.ts, and removes the onDomEditPersisted shadow callback from useDomEditSession. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
…nwired) Stage 7 s7.5 removed the feature flag and declared cutover 'always-on', but onTrySdkPersist was never actually passed to useDomEditCommits — the sdkCutoverPersist function was dead code in production. Thread sdkSession through useDomEditSession params, build the onTrySdkPersist closure there (all CutoverDeps are already in scope), and pass sdkSession from App.tsx. Style/text/attribute/html-attribute commits now route through SDK dispatch instead of the server patch path. Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
…onally deferred (§3.3) Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>
…rride-set cleanup
vanceingalls
force-pushed
the
06-15-fix_studio_core_resolve_sdk-cutover_review_findings
branch
from
dcc46d5 to
dc32ca8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved onto
06-15-fix_studio_core_resolve_sdk-cutover_review_findingsvia gt move (conflict resolution).Replaces closed PR #1488.
Summary
🤖 Generated with Claude Code