Trade Log count matches the table (excludes spot HOLDINGs) - #138
Merged
Conversation
…tory) The top-right count read displayRows.length, which included spot HOLDINGs (rendered as cards, not table rows) — so it disagreed with Open Positions + Position History. Count non-HOLDING rows instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top-right Trade Log count read
displayRows.length, which included spot HOLDINGs — but HOLDINGs render as cards, not table rows. So the header (e.g. "4 trades") disagreed with Open Positions + Position History (e.g. 2 open).Now it counts non-HOLDING rows (open + history), matching what's actually in the table.
Build + 183 tests pass.
🤖 Generated with Claude Code