Add Edit button to open positions - #139
Merged
Merged
Conversation
Open positions only had quick-outcome/Close/delete actions — no way to open the edit modal to fix strike/premium/expiry/size on an in-flight trade. Add an Edit button mirroring history rows; the modal already handles OPEN via the OUTCOMES registry.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open positions only had quick-outcome / Close / delete actions — there was no way to open the edit modal to correct strike, premium, expiry, or size on an in-flight trade (you'd have to delete and re-add).
Adds an Edit button to open positions in both the table rows and the mobile cards, mirroring the existing history rows. The edit modal already handles OPEN trades (the
OUTCOMESregistry includesOPEN), so no modal changes were needed — the button was the only missing piece.New test:
open positions expose an Edit button (both apps). Build + 184 tests pass.🤖 Generated with Claude Code