Count CLOSED (buy-to-close) as a settled position - #141
Merged
Conversation
calcPremiumStats only treated EXPIRED/ASSIGNED/CALLED as settled, so buy-to-close positions showed '0 positions settled' and were excluded from Return Rate. Count CLOSED as settled (premium kept, no assignment) and fix the Total Premium tooltip which wrongly claimed 'gross' when the value is net of buy-to-close costs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Wheeler's Premium Economics showed "0 positions settled" despite closed-early (buy-to-close) positions in Position History.
calcPremiumStatsonly treatedEXPIRED/ASSIGNED/CALLEDas settled, soCLOSEDrows fell through — excluded from the settled count and from Return Rate.Fix
CLOSEDas a settled outcome (premium kept, no assignment/call-away) — added tosettledand to the Return Rate numerator.premium − closeCost). Tooltip now says net.Build + 191 tests green.