Repository navigation
fix: finalmask domains drop proxies from the app subscription - #47
Open
AnonymousContributorAlpha wants to merge 2 commits into
Open
AnonymousContributorAlpha wants to merge 2 commits into
AnonymousContributorAlpha wants to merge 2 commits into
Conversation
…s in the newer versions of hiddify app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line fix for a regression from 526eadf (
feat: add finalmask support to hiddify-core).Bug:
hiddify-core/client/snippets/finalmaskgated onctx.platform.hiddify_core.version, which doesn't exist on the clientPlatformVar(client side exposesctx.platform.hiddify/.singbox/.xray). Any proxy bound to a domain carrying afinalmaskextra therefore failed its render with'PlatformVar' object has no attribute 'hiddify_core', and the panel dropped that whole outbound from the hiddify-core/singbox profiles: all xhttp/ws/grpc/httpupgrade vless/vmess/trojan configs bound to such domains vanished from the Hiddify app subscription, while sub-link/clash/xray profiles kept them.Fix: gate on
ctx.platform.hiddify.version, matching the other hiddify-core client fragments; the >= 5.0.0 intent is preserved.Verified on a live 14.0.0b13 panel (domains with finalmask extras, HiddifyNext/5.0.0 UA): render errors 24 -> 0, with
HiddifyNext/2.7.0the configs render without the finalmask field.