Draft
Conversation
Contributor
Author
|
@PaulDalek what do you think about this type of defining colors and styles? Is it okay here in this use case or should we handle them differently? |
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Co-authored-by: Burkhard Vogel-Kreykenbohm <burkhard.vogel@gmx.net>
Contributor
Author
|
Thanks @bvogel! Great suggestions, all applied. |
|
Glad you liked them, hopefully this get's merged and released soon! |
|
too bad, didn't make it into 4.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
The goal of this pull request is to get rid of the unnecessary
colorsdependency and perform a slight refactoring of the logging logic. The logging statements (even the longer ones) were shared across multiple files even though they have been exactly the same. If someone wanted to modify them in the future, he or she would have to modify 8 files (which might get tricky).Tasks
colorspackagelogger.jsand most console log statements