Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## 12.4.3
- **FIX**(state-manager): Update activeFilters and activeTuneAdjustments to directly use historyPointer.

## 12.4.2
- **FEAT**(state-manager): Add `replaceHistory()` to replace an existing history entry in the stack (current pointer by default, or a custom index).

Expand Down
16 changes: 3 additions & 13 deletions lib/features/main_editor/services/state_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -106,19 +106,9 @@ class StateManager {
void updateActiveItems() {
var activeHistory = _stateHistory.getRange(0, _historyPointer + 1);

activeFilters = activeHistory
.lastWhere(
(item) => item.filters.isNotEmpty,
orElse: EditorStateHistory.new,
)
.filters;

activeTuneAdjustments = activeHistory
.lastWhere(
(item) => item.tuneAdjustments.isNotEmpty,
orElse: EditorStateHistory.new,
)
.tuneAdjustments;
activeFilters = _stateHistory[historyPointer].filters;

activeTuneAdjustments = _stateHistory[historyPointer].tuneAdjustments;

activeLayers = _stateHistory[historyPointer].layers;

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: pro_image_editor
description: "A Flutter image editor: Seamlessly enhance your images with user-friendly editing features."
version: 12.4.2
version: 12.4.3
homepage: https://github.com/hm21/pro_image_editor/
repository: https://github.com/hm21/pro_image_editor/
documentation: https://github.com/hm21/pro_image_editor/
Expand Down
4 changes: 2 additions & 2 deletions test/shared/services/import_export/import_export_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ void main() {
editor,
onAfterImport: () {
editor.addHistory(filters: const []);
expect(editor.stateManager.activeFilters.allMatrices.length, 1);
expect(editor.stateManager.activeFilters.allMatrices.length, 0);
},
);

Expand Down Expand Up @@ -179,7 +179,7 @@ void main() {
editor,
onAfterImport: () {
editor.addHistory(tuneAdjustments: []);
expect(editor.stateManager.activeTuneAdjustments.length, 1);
expect(editor.stateManager.activeTuneAdjustments.length, 0);
},
);

Expand Down
Loading