fix: make omitted component keys optional in world.without#321
Closed
fuleinist wants to merge 1 commit into
Closed
fix: make omitted component keys optional in world.without#321fuleinist wants to merge 1 commit into
fuleinist wants to merge 1 commit into
Conversation
Issue hmans#320: The Without type now uses Omit<E, P> & Partial<Pick<E, P>> instead of plain Omit<E, P>, making omitted component keys optional so they can be re-added within query loops.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Author
|
Stale PR (no maintainer activity for 4+ weeks). Feel free to reopen if still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320.
The
Without<E, P>type was using plainOmit<E, P>, which removes the specified component keys entirely from the entity type. This makes it impossible to re-add those components within a query loop.This change makes omitted component keys optional instead:
Omit<E, P> & Partial<Pick<E, P>>.Before: TypeScript would error if you tried to add back a component that was removed via
.without()inside a query loop.After: The omitted keys become
undefined(optional), allowing re-addition without type errors.Tests pass (76 tests across 5 suites).