Skip to content

perf: memoize IssueCard to avoid unnecessary rerenders #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ELITE-DEV-22 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

perf: memoize IssueCard to avoid unnecessary rerenders #37

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2db7af
perf: memoize IssueCard to avoid unnecessary rerenders
ELITE-DEV-22 May 31, 2026
df0c6eb
revised perf: memoize IssueCard to avoid unnecessary rerenders
ELITE-DEV-22 May 31, 2026
62f8441
fix(ui): restore action badge icons and issue-actions wrapper
ELITE-DEV-22 Jun 1, 2026
2477352
revert: remove ISSUE_INFO entries that lack corresponding detectors
ELITE-DEV-22 Jun 2, 2026
34f3de6
Merge remote-tracking branch 'upstream/main' into fix/memoize-issuecard
ELITE-DEV-22 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/panel/components/IssueCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from 'react';
import React, { useState } from 'react';
import type { Issue } from '@/types';

interface IssueCardProps {
Expand All @@ -12,6 +12,7 @@ const SEVERITY_CONFIG = {
};

const ISSUE_INFO: Record<string, { title: string; why: string; learnUrl?: string }> = {

MISSING_KEY: {
title: 'Missing Key in List',
why: 'Keys help React identify which items have changed, are added, or removed.',
Expand Down Expand Up @@ -54,13 +55,13 @@ const ISSUE_INFO: Record<string, { title: string; why: string; learnUrl?: string
},
};

export function IssueCard({ issue }: IssueCardProps) {
const [expanded, setExpanded] = useState(false);
export const IssueCard = React.memo(function IssueCard({ issue }: IssueCardProps) {

const [expanded, setExpanded] = useState(false);
const severity = SEVERITY_CONFIG[issue.severity];
const info = ISSUE_INFO[issue.type] || { title: issue.type, why: '' };
const location = issue.location;

const renderCountMatch = issue.message.match(/Rendered (\d+) times/);
const renderCount = renderCountMatch ? parseInt(renderCountMatch[1], 10) : null;

Expand All @@ -74,12 +75,12 @@ export function IssueCard({ issue }: IssueCardProps) {
<div className="issue-info">
<div className="issue-title-row">
<h4 className="issue-title">{info.title}</h4>
<span
className="severity-badge"
style={{
backgroundColor: severity.bgColor,
<span
className="severity-badge"
style={{
backgroundColor: severity.bgColor,
color: severity.color,
border: `1px solid ${severity.color}`
border: `1px solid ${severity.color}`,
}}
>
{severity.label}
Expand Down Expand Up @@ -151,7 +152,7 @@ export function IssueCard({ issue }: IssueCardProps) {
</span>
</div>
</div>

<div className="closure-details">
<div className="closure-row">
<span className="closure-label">Function:</span>
Expand Down Expand Up @@ -207,7 +208,7 @@ export function IssueCard({ issue }: IssueCardProps) {
</div>
)}

<div className="issue-actions">
<div className="issue-actions">
{info.learnUrl && (
<a
href={info.learnUrl}
Expand All @@ -223,4 +224,4 @@ export function IssueCard({ issue }: IssueCardProps) {
)}
</div>
);
}
});