age model test updates#4
Open
jabadge wants to merge 14 commits intohoffmaao:agefrom
Open
Conversation
Author
|
Some of these new commits are actually old ones that overlap with the cleanup you recently did. We can squash and/or remove them now or later. |
Author
|
Check out the updated pull request. I dropped the excess commits. I don't think I did any harm (the age model test notebook still runs fine), but that was my first time using interactive rebasing to drop commits. |
because I can never find it easily
Before, quadrature degree setting occured inside FlowSolver. This has the unfortunate effect of leaving the adjoint solver with no way to know what quadrature degree to use (barring upstream fixes in Firedrake and pyadjoint). The adjoint solver then uses the default, conservative quadrature estimation, resulting in annoying warnings and low performance. This patch puts quadrature degree in by adding it to the metadata of all the measures (dx, ds, etc.) in the action functionals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new commits add my work on the age model test and fix a few bugs that existed in this branch.