Skip to content

Add Spanish locale#30

Open
CarlosEstebanTanantaSantaCruz wants to merge 1 commit into
holistics:mainfrom
CarlosEstebanTanantaSantaCruz:add-spanish-locale
Open

Add Spanish locale#30
CarlosEstebanTanantaSantaCruz wants to merge 1 commit into
holistics:mainfrom
CarlosEstebanTanantaSantaCruz:add-spanish-locale

Conversation

@CarlosEstebanTanantaSantaCruz
Copy link
Copy Markdown

Summary

Added initial Spanish translation for dbdiagram/dbdocs.

Changes

  • Added locales/es translation files.
  • Added Spanish metadata in locales/metadata.yaml.
  • Registered Spanish messages in src/index.js.
  • Generated Spanish locale build output.

Validation

  • Verified build with yarn.cmd build.

Lasting Changes (Technical)

  • Added a new Spanish locale (es) to the localization system.
  • Registered esMessages in the exported messages object.
  • Added Spanish metadata for frontend language discovery.

Checklist

Please check directly on the box once each of these are done:

  • Documentation (if necessary)
  • Lint Checks Passed
  • Unit Tests Passed
  • Coverage Tests Passed
  • Integration Tests Passed
  • Code Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive Spanish translations across the application, including account management, AI assistant features, authentication, billing, and the diagram renderer. The changes involve adding several new YAML locale files, updating the metadata, and registering the Spanish locale in the source code. Review feedback highlighted several instances in databaseGuidelines.yaml and dbrenderer.yaml where strings remained in English or contained encoding errors, providing specific Spanish translations to ensure consistency.

Comment on lines +10 to +17
install: Install # Install link text
tool: mysqldump # Tool name
terminalCommand: In your terminal run the following command # Instruction (command block)
linuxPrefix: On Linux you might need to add # Linux-specific note
sudo: sudo # Sudo command
linuxSuffix: before it # Sudo placement hint
example: Example # Command block label
step3: Copy the dumped SQL content and paste it into this modal # Final step instruction
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Several strings in this section are still in English. They should be translated to Spanish to maintain consistency with the rest of the locale files.

    install: Instalar # Install link text
    tool: mysqldump # Tool name
    terminalCommand: En tu terminal, ejecuta el siguiente comando # Instruction (command block)
    linuxPrefix: En Linux, es posible que necesites añadir # Linux-specific note
    sudo: sudo # Sudo command
    linuxSuffix: antes # Sudo placement hint
    example: Ejemplo # Command block label
    step3: Copia el contenido SQL volcado y pégalo en este modal # Final step instruction

Comment on lines +9 to +12
title: Tables # Panel title (left sidebar header)
diagramViews: Diagram Views # Dropdown header for views (table search panel)
diagramViewsTooltip: Diagram views are collections of tables that represent specific domains or workflows in your database. # Tooltip for views dropdown
viewActions: View actions # Dropdown header for view actions
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

These UI labels are still in English. Please translate them to Spanish.

    title: Tablas # Panel title (left sidebar header)
    diagramViews: Vistas de diagrama # Dropdown header for views (table search panel)
    diagramViewsTooltip: Las vistas de diagrama son colecciones de tablas que representan dominios o flujos de trabajo específicos en tu base de datos. # Tooltip for views dropdown
    viewActions: Acciones de vista # Dropdown header for view actions

diagramViews: Diagram Views # Dropdown header for views (table search panel)
diagramViewsTooltip: Diagram views are collections of tables that represent specific domains or workflows in your database. # Tooltip for views dropdown
viewActions: View actions # Dropdown header for view actions
cannotRenameOrDelete: Cannot rename or delete the {name} # Error toast (default view protection)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This error message is still in English.

    cannotRenameOrDelete: No se puede renombrar o eliminar {name} # Error toast (default view protection)

snowflake: Snowflake # Algorithm option (snowflake schema layout)
compact: Compact # Algorithm option (compact layout)
confirmMessage: Your diagram will be automatically rearranged and you will not be able to undo. Are you sure? # Warning in modal body
confirm: Confirm (↵) # Confirm button (with Enter shortcut)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The text is untranslated and contains an encoding issue (↵).

    confirm: Confirmar (↵) # Confirm button (with Enter shortcut)

stickyNotes:
untitledNote: Untitled Note # Default name for new notes
removeNoteConfirmation: Remove your note? # Delete confirmation dialog title
'yes': 'Yes' # Confirm button (delete note)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The label for 'yes' should be translated to Spanish.

    'yes': '' # Confirm button (delete note)

# Record Preview - Preview data sample modal
# ========================================
recordPreviewModal:
infoTooltip: View example rows to quickly understand the table’s data
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This tooltip is untranslated and contains an encoding error (table's).

    infoTooltip: Ver filas de ejemplo para comprender rápidamente los datos de la tabla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant