grpc: split combined Get RPC into GetState and GetConfig#36
Open
Shbinging wants to merge 1 commit into
Open
Conversation
Shbinging
force-pushed
the
grpc-getstate-getconfig
branch
from
July 13, 2026 08:15
ce8071b to
35d29e4
Compare
Contributor
|
This is already covered in PR #34 by @Paul-weqe |
holod removed the combined `Northbound.Get(GetRequest)` RPC and replaced it with dedicated `GetState(GetStateRequest)` and `GetConfig(GetConfigRequest)` RPCs (holod commit "separate state and configuration retrieval"). holo-cli still spoke the old combined RPC, so every state/config retrieval failed with gRPC `Unimplemented`, breaking `show state`, `show ... route`, the running config load at startup, etc. Sync proto/holo.proto with holod's northbound service (drop `Get`, add `GetState`/`GetConfig` and their request/response messages) and dispatch in GrpcClient::get() accordingly: - DataType::Config -> GetConfig - DataType::State -> GetState - DataType::All -> issue both and merge the two data trees, reproducing the semantics the combined RPC used to provide for callers that ask for config and state at once. Cargo.lock: pull in yang5 0.2 (data-tree parse/merge APIs used above), matching the Cargo.toml bump already on main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Shbinging
force-pushed
the
grpc-getstate-getconfig
branch
from
July 13, 2026 08:38
35d29e4 to
d10e6c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
holod replaced the combined
GetRPC with separateGetStateandGetConfigRPCs, so holo-cli's oldGetcalls now fail withUnimplemented, breakingshow state,show ... route, the startup config load, etc.Sync
proto/holo.protowith holod and dispatch inGrpcClient::get():Config→GetConfigState→GetStateAll→ issue both and merge the two data trees