Skip to content

Stop pnpm check from running scripts that no longer exist - #68

Merged
leggetter merged 1 commit into
mainfrom
fix-pnpm-check
Aug 29, 2026
Merged

Stop pnpm check from running scripts that no longer exist#68
leggetter merged 1 commit into
mainfrom
fix-pnpm-check

Conversation

@leggetter

Copy link
Copy Markdown
Collaborator

pnpm check has failed since d69e572 removed the Supabase runtime.

The framework's check ended in pnpm test:framework, which pointed at scripts/smoke-framework.ts — deleted by that commit. So the gate that validates a scorer or harness change died at its last step, after every test in the repository had already passed. That is the worst way for a gate to fail: it looks like a broken checkout rather than a stale script, and it teaches people to stop running it.

CI never caught it, because CI runs typecheck, pnpm -r test and pnpm -r build directly rather than through check.

Three more scripts pointed at files that are not there:

script points at status
test:framework scripts/smoke-framework.ts deleted by d69e572
demo:mcp scripts/mcp-demo.ts deleted by d69e572
demo:executor scripts/executor-demo.ts deleted by d69e572
eval:force (root) framework eval:force has never existed here — came in with the import

pnpm check now runs clean: 222 tests across four packages.

Split out of #67 so the gate is fixed independently of the scenario change it was found by.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MQzUoMAwEBJWpEGVvVzSjK

`pnpm check` has failed since d69e572 removed the Supabase runtime. The
framework's `check` ended in `pnpm test:framework`, which pointed at
`scripts/smoke-framework.ts` — deleted by that commit — so the gate that
validates a scorer or harness change died at its last step, after every test in
the repository had already passed. The failure looks like a broken checkout
rather than a stale script, which is the worst way for a gate to fail: it
teaches people to stop running it.

CI never caught it because CI runs `typecheck`, `pnpm -r test` and `pnpm -r
build` directly rather than through `check`, so the entry could rot untouched.

Three more scripts pointed at files that are not there: `demo:mcp` and
`demo:executor` (both deleted by the same commit) and a root `eval:force`,
which proxies to a framework script that has never existed in this repository —
it came in with the import and was never wired up.

`pnpm check` now runs clean: 222 tests across four packages.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MQzUoMAwEBJWpEGVvVzSjK
@leggetter
leggetter merged commit a5f6ebf into main Aug 29, 2026
2 checks passed
@leggetter
leggetter deleted the fix-pnpm-check branch August 29, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant