ci(sdk-regen): use SDK_REGEN_GITHUB_PAT for TS regen so downstream CI fires#941
Open
leggetter wants to merge 1 commit into
Open
ci(sdk-regen): use SDK_REGEN_GITHUB_PAT for TS regen so downstream CI fires#941leggetter wants to merge 1 commit into
leggetter wants to merge 1 commit into
Conversation
… fires Closes #939. GitHub Actions suppresses workflow triggers for PRs opened with GITHUB_TOKEN. The TS SDK regen was opening its PR with GITHUB_TOKEN, so spec-sdk-tests.yml (#925) and spec-sdk-tests-vs-release.yml (#927) never fired on the bot's PR. Swap to a PAT in the two sites that open TS regen PRs: * sdk_generation_outpost_ts.yaml (manual dispatcher) * sdk-generate-on-release.yml (generate-ts job) Requires SDK_REGEN_GITHUB_PAT repo secret with Contents, Pull requests, and Workflows read+write.
Contributor
There was a problem hiding this comment.
Pull request overview
Swaps the default GITHUB_TOKEN for a user-provided PAT (SDK_REGEN_GITHUB_PAT) in the two TypeScript SDK generation entry points, so that bot-opened SDK regen PRs trigger downstream pull_request workflows (spec-sdk-tests.yml, spec-sdk-tests-vs-release.yml). GitHub Actions intentionally suppresses workflow runs for PRs opened with GITHUB_TOKEN; using a PAT makes the PR look user-authored and re-enables the gates.
Changes:
- TS manual dispatch workflow now passes
SDK_REGEN_GITHUB_PATasgithub_access_token. - Release-triggered TS regen job in
sdk-generate-on-release.ymllikewise swapped to the PAT. - Go and Python generation paths intentionally left on
GITHUB_TOKEN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/sdk_generation_outpost_ts.yaml |
Manual TS dispatcher now uses the PAT secret for the reusable generator call. |
.github/workflows/sdk-generate-on-release.yml |
generate-ts job uses the PAT; generate-go/generate-python unchanged. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #939.
What
Two-site swap of
secrets.GITHUB_TOKEN→secrets.SDK_REGEN_GITHUB_PATin the TS SDK regen workflow chain. Go and Python keepGITHUB_TOKEN(their bot PRs aren't gated by a TS-only test suite)..github/workflows/sdk_generation_outpost_ts.yaml.github/workflows/sdk-generate-on-release.ymlgenerate-tsjob (Go and Python jobs unchanged)Why
GitHub Actions deliberately suppresses workflow triggers for PRs opened with
GITHUB_TOKEN. Empirically confirmed today: Go (#935) and Python (#937) v1.4.0 bot PRs merged withoutspec-sdk-tests.yml(#925) orspec-sdk-tests-vs-release.yml(#927) firing — the whole point of those workflows was to gate exactly that scenario.By swapping to a PAT, PR events look like they came from a user and trigger downstream workflows normally.
Required before merge
Create the
SDK_REGEN_GITHUB_PATrepo secret. Fine-grained PAT onhookdeck/outpostwith:Test plan
sdk_generation_outpost_ts.yamland confirm the resulting bot PR triggersspec-sdk-tests.yml.🤖 Generated with Claude Code