fix: reconcile gateway with v5 protocol changes - #238
Merged
Conversation
Keep protocol preparation errors visible within the engine and update the byte-exact unique-key artifact with its emitted protocol hash. No assertions or authorization checks are relaxed.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The gateway and protocol changes passed independently but exposed two integration failures when combined on v5 (PR #227).
Changes
No error classification, authorization checks, or tests are weakened. No user-facing copy changes.
Validation
Intermittent test observed
The initial gateway application run failed the delivery-enabled Todo DOM-continuity assertion during token refresh. Three local runs (including 6x CPU throttling) and the CI rerun passed without changing that test or runtime behavior. The underlying timing issue remains unexplained; it is not claimed fixed by this PR. Temporary diagnostics were removed. All other initial CI checks passed.
Follow-up to #228 and #236/#237. Targets v5 to repair #227.