Skip to content

fix: reconcile gateway with v5 protocol changes - #238

Merged
patrickleet merged 1 commit into
v5from
fix/v5-gateway-integration
Sep 9, 2026
Merged

fix: reconcile gateway with v5 protocol changes#238
patrickleet merged 1 commit into
v5from
fix/v5-gateway-integration

Conversation

@patrickleet

@patrickleet patrickleet commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Why

The gateway and protocol changes passed independently but exposed two integration failures when combined on v5 (PR #227).

Changes

  • Give ProtocolPreparationError engine-scoped visibility, matching the protocol_accumulator method consumed by sibling read-routing code. It remains outside the public API.
  • Add the compiler-emitted protocolHash to the unique-key runtime fixture. The byte-exact assertion remains unchanged.

No error classification, authorization checks, or tests are weakened. No user-facing copy changes.

Validation

  • cargo test -p distributed_cli --lib: 250 passed.
  • Gateway GraphQL, operation, causal transport, query protocol, identity, GraphQL SQLite and SQLite repository suites: 81 passed, 3 existing ignored tests, 0 failures, with gateway-graphql-native,gateway-delivery,sqlite enabled.
  • git diff --check: passed.
  • Rust quality CI run 34310936117: success, including native/kind browsers and live celld.
  • Gateway CI run 34310935513 attempt 2: success, including production/dev auth flows and controlled restart/reloads.

Intermittent test observed

The initial gateway application run failed the delivery-enabled Todo DOM-continuity assertion during token refresh. Three local runs (including 6x CPU throttling) and the CI rerun passed without changing that test or runtime behavior. The underlying timing issue remains unexplained; it is not claimed fixed by this PR. Temporary diagnostics were removed. All other initial CI checks passed.

Follow-up to #228 and #236/#237. Targets v5 to repair #227.

Keep protocol preparation errors visible within the engine and update the byte-exact unique-key artifact with its emitted protocol hash. No assertions or authorization checks are relaxed.
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 06935f63-65b4-44eb-9bda-cd6a5b571be4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet
patrickleet merged commit fdc0a79 into v5 Sep 9, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant