feat(graphql): add literal case-insensitive text filters - #240
Open
patrickleet wants to merge 2 commits into
Open
feat(graphql): add literal case-insensitive text filters#240patrickleet wants to merge 2 commits into
patrickleet wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
patrickleet
force-pushed
the
feat/literal-text-filter
branch
from
September 9, 2026 09:17
ab201a8 to
c83252f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stacked on #239 (
fix/private-live-snapshots, itself targetingv5). This keeps the review diff focused on literal filters while CI exercises both changes together. Merge #239 first, then retarget this PR tov5.A search box should pass the user's text to GraphQL. Today
_ilikerequires the caller to construct and escape a SQL pattern. That duplicates database-specific work across SSR, URL bindings and browser queries—and a missed escape turns a search for%or_into a wildcard query.This adds
_icontainsto String comparison inputs. The query engine owns the escaping and parameter binding; applications can use a normal URL-bound variable.Before / after
Before, callers construct an escaped
%...%pattern before running:After, a colocated island takes literal search text directly:
Contract
%,_, backslash, quotes and the escape character are literal characters. SQL uses a bound escaped pattern and explicitESCAPEon both PostgreSQL and SQLite._ilikeretains intentional pattern semantics;_containsremains JSON containment. Numeric columns do not expose the new operator.The generated schema fingerprint changes, so regenerate the application coherently with
distributed build/distributed dev.Validation
_ilikebehavior.@loadgeneration, read-only drift checking and invalid-operand rejection.No user-facing UI copy is added. README examples document the API; no application pages or controls change in this PR.