fix: retire disposed live ownership - #242
Open
patrickleet wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retire local live-query ownership when the last watch for a stream is disposed,
then let a later snapshot stream take over shared nested indexes. The runtime
keeps the retirement boundary in operation metadata so callbacks from a stream
that started before disposal remain fenced, while a stream started afterward
can populate the current page immediately.
User benefit
Navigation between pages that share nested relationship data no longer leaves
the new page stuck behind a disposed page's membership. The replacement page
can render its authorized snapshot without a refresh or polling workaround.
Scope and ordering
The boundary is scoped to one replica's live-operation lifecycle. It is local
runtime ownership/order metadata, not a server clock, projection position, or
claim that the server stopped producing events. Reopening an operation clears
the retired marker before synchronous transport callbacks arrive. Hydration
preserves retired boundaries and does not replace an already active receiver's
ownership.
Verification
npm run buildnpm run checknpm test— 384 passed, 0 failedgit diff --checkBefore the fix, the regression test
snapshot live takes over a nested graph from a disposed page subscriptionfailed with0 !== 1: the disposed-pageowner continued to block the later snapshot stream.
User-facing copy
No user-facing copy was added.