Skip to content

Comment out proto formatter to fix the build#4

Merged
hopskipnfall merged 4 commits intomasterfrom
add-protos
Aug 14, 2025
Merged

Comment out proto formatter to fix the build#4
hopskipnfall merged 4 commits intomasterfrom
add-protos

Conversation

@hopskipnfall
Copy link
Copy Markdown
Owner

Sorry #3 was not ready to be merged, it broke GitHub's CI testing due to a strange permission error. Let's have the author merge the CL manually after approval from now on.

@russell-jeter
Copy link
Copy Markdown
Collaborator

@hopskipnfall My policy has always been to make a PR a draft if it isn't ready for merging. Is there a better system or were you just being loose with this project?

@hopskipnfall
Copy link
Copy Markdown
Owner Author

@hopskipnfall My policy has always been to make a PR a draft if it isn't ready for merging. Is there a better system or were you just being loose with this project?

@russell-jeter This is my first experience doing a code review on gh, I haven't heard of draft PRs before 😅. I'm just following the review practice I'm used to at work:

  1. Send PR out for review
  2. Automated CI runs linter, checks that it builds, checks that the tests pass, and blocks merging if anything fails
  3. Iterate with reviewer on changes
  4. Get approval from reviewer
  5. Final checks, at most very small post-approval changes. If anything significant changes or new files get added, ask for re-approval
  6. Merge PR (potentially auto-merge if enabled at review time)
  7. Reviewers are notified of any post-approval changes

It's often helpful for the author to control the submission time so they can control when something gets released (especially in the case of config files which might be deployed immediately upon submission) or to make dealing with merge conflicts easier.

Things might be different on gh though..

@hopskipnfall hopskipnfall merged commit 0b090eb into master Aug 14, 2025
1 check passed
@hopskipnfall hopskipnfall deleted the add-protos branch August 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants