Comment out proto formatter to fix the build#4
Conversation
|
@hopskipnfall My policy has always been to make a PR a draft if it isn't ready for merging. Is there a better system or were you just being loose with this project? |
@russell-jeter This is my first experience doing a code review on gh, I haven't heard of draft PRs before 😅. I'm just following the review practice I'm used to at work:
It's often helpful for the author to control the submission time so they can control when something gets released (especially in the case of config files which might be deployed immediately upon submission) or to make dealing with merge conflicts easier. Things might be different on gh though.. |
Sorry #3 was not ready to be merged, it broke GitHub's CI testing due to a strange permission error. Let's have the author merge the CL manually after approval from now on.