Rebase on horde/yaml document layer#2
Merged
Conversation
Constructor uses YamlFileLoader instead of Yaml::load(). Two new helpers (streamToArray, nodeToArray) reduce the AST to the plain PHP array that arrayToObject already consumes. Empty-file branch dropped: documentCount()==0 yields []. Bare- scalar roots collapse to an empty top-level map. Multi-doc files collapse to the first document. Save side still uses the legacy dumper. Wire-up comes in step 3. Composer: horde/yaml ^3.0.0RC1 || dev-FRAMEWORK_6_0. 168 tests green.
Add private $stream: YamlStream slot. The constructor now stores the loaded AST in addition to the legacy stdClass facade. Save side and __toString still use the legacy dumper; that wire-up comes in step 3. 168 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load via YamlFileLoader, emit via YamlFileDumper. Top-level diff-and-apply syncer preserves comments and blank lines around unchanged entries.
stdClass facade unchanged. Sub-object fromStdClass/toStdClass contracts unchanged. Public API unchanged.
Composer: horde/yaml ^3.0.0RC1 || dev-FRAMEWORK_6_0.
168 existing tests green plus 9 new round-trip fidelity tests.