Repository navigation
Feat/binary Add opt-in byte-preserving binary APPEND to legacy socket - #58
Merged
Merged
Conversation
PR Summary
|
ralflang
approved these changes
Nov 2, 2026
ralflang
left a comment
Member
There was a problem hiding this comment.
I need to ensure after merging there is a feature parity for the src/ branch.
ralflang
added a commit
that referenced
this pull request
Nov 3, 2026
…o spec - Validates the BINARY capability (batch-wide, before any send) - Rejects a url part combined with binary (CapabilityNotSupportedException (RFC 4469). - Concatenates the TEXT parts locally into one php://temp stream and sends it as a single literal8 via ImapWireStream(forceBinary: true) - Updated the docblock This is informed by lib/ PR #58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy socket APPEND implementation normalizes line endings throughout the message, which can alter binary MIME payloads.
This adds a per-message
binaryoption:When enabled, the client preserves bytes, requires the server’s BINARY capability, and sends a literal8 (
~{n}). Server rejection does not trigger a fallback to ordinary APPEND. CATENATE inputs are assembled locally because RFC 4469 TEXT parts do not permit literal8.Callers must supply a valid MIME message with CRLF headers and appropriate content-transfer-encoding. Existing behavior remains unchanged when the option is omitted or false. The modern namespaced API is unchanged.
Validation
Protocol references