Repository navigation
Feat/api Add decoded partial BINARY FETCH to the modern IMAP API - #61
Merged
Merged
Conversation
PR Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modern API can tokenize binary literals but lacks public query builders for decoded MIME content and decoded sizes.
This adds RFC 3516 BINARY FETCH support:
Behavior
Live testing also exposed an existing tokenizer issue: socket reads can return fewer bytes than requested. The tokenizer now reads until the literal’s announced length is reached and closes the connection if the literal is incomplete.
Memory behavior
The tokenizer still materializes each requested literal. Callers handling large objects should issue bounded partial FETCH requests and process each result before requesting the next range. An unrestricted FETCH is not memory-bounded by this change.
Validation
This branch is based directly on FRAMEWORK_6_0.
Reference: RFC 3516 §§4.2–4.3.