Skip to content

feat(imp): handle COUNTER accept/decline workflows and proposal updates#67

Merged
TDannhauer merged 3 commits into
FRAMEWORK_6_0from
feat/Initial_EAS16.1-support
Jun 18, 2026
Merged

feat(imp): handle COUNTER accept/decline workflows and proposal updates#67
TDannhauer merged 3 commits into
FRAMEWORK_6_0from
feat/Initial_EAS16.1-support

Conversation

@TDannhauer

@TDannhauer TDannhauer commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Address PR review feedback on COUNTER accept/decline handling in IMP iTIP
  • Catch Horde_Exception with logging on counter-decline errors
  • Use HordeString instead of legacy Horde_String in DECLINECOUNTER mail body
  • Use use import for Variables in the ItipRequest test stub

Motivation

Review on #67 requested tighter exception handling, modern string API usage, and import style in new code.

Changes

lib/Ajax/Imple/ItipRequest.php

  • counter-decline: catch Horde_Exception instead of Exception; log via Horde::log($e, Horde_Log::ERR) before user notification
  • _sendDeclineCounter(): HordeString::wrap() with use Horde\Util\HordeString

Expected exceptions on counter-decline:

  • Horde_Exception — missing attendee address, identity lookup, MIME assembly/send failures

test/Imp/Stub/ItipRequest.php

  • Add use Horde\Util\Variables for the handle() union type parameter

Test plan

  • vendor/bin/phpunit -c phpunit.xml.dist test/Imp/Unit/Ajax/Imple/ItipRequestCounterTest.php
  • Manual: open COUNTER mail in IMP — accept/decline actions unchanged
  • Regression: normal REQUEST accept/decline/tentative unchanged

Review responses

Comment Resolution
Do not catch random Exception without logging Catch Horde_Exception; log with Horde::log() before notification
Prefer HordeString over Horde_String HordeString::wrap() in _sendDeclineCounter()
Use use instead of FQCN in stub use Horde\Util\Variables

* add counter accept/decline actions for iTIP viewer/request handler
* update attendee state with proposal persistence on counter flows
* add unit tests for counter accept/decline/update action paths
@TDannhauer TDannhauer requested a review from ralflang June 17, 2026 13:44
Comment thread lib/Ajax/Imple/ItipRequest.php Outdated
Comment thread lib/Ajax/Imple/ItipRequest.php Outdated
Comment thread test/Imp/Stub/ItipRequest.php Outdated
Catch Horde_Exception with logging on counter-decline, use HordeString
in DECLINECOUNTER mail body, and import Variables in test stub.
@TDannhauer TDannhauer requested a review from ralflang June 18, 2026 07:28
@TDannhauer

Copy link
Copy Markdown
Contributor Author

PR adapted.

@TDannhauer TDannhauer merged commit 326694d into FRAMEWORK_6_0 Jun 18, 2026
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants