Add secret manager #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Credential enum (None, SecretRef) for storing credential references - Add ResolvedCredential<'a> borrowed view for runtime credential access - Add with_resolved_credential() closure pattern for scoped plaintext - Update connection_string() to accept ResolvedCredential parameter - Remove plaintext password fields from Source variants
- Update discover_tables() and fetch_table() signatures - Add resolve_connection_string() helper in duckdb and postgres drivers - Update FetchOrchestrator to store and use secret_manager
- Add secret_key field to RivetEngineBuilder - Auto-populate from RIVETDB_SECRET_KEY env var in new() - Allow override via .secret_key() method for tests - Reorder build() to create secret_manager before orchestrator
- Update datafetch tests for new API signatures - Add test secret key generation to TestHarness - Update PostgresFixture to use SecretRef credentials - Store password as secret before Postgres connection tests
RIVETDB_SECRET_KEY is now required at engine startup. Without it, connections with credentials would fail silently at query time.
Split CatalogManager secret methods into metadata (all providers) and encrypted storage (EncryptedSecretManager only). Removes FK constraint between tables. Adds rollback on metadata failure with test coverage.
Extract storage logic into SecretBackend trait, separating metadata coordination from value persistence to enable pluggable backends.
# Conflicts: # src/http/app_server.rs # src/http/handlers.rs # tests/http_server_tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17.