Add IP address logging in relay components#187
Open
codemaster1104 wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks! Looks reasonable, but let me think about this more. It seems to me that it would make sense to abstract the connection logging framework somehow. |
Contributor
Author
|
sounds good , should i work on a creating a helper function to abstract this logging message |
Owner
|
Sure, if you have the time that would be great, thanks! Maybe make a prototype of the function and we can discuss it before doing all the work of updating everywhere? |
Contributor
Author
|
Cool will share my implementation plans here before, will update shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added [ID IP] logging to majority relay components.
This was listed as a TODO task in the repo