feat(relay): add maxTotalEventsPerReq to cap aggregate events across filters#208
Open
Thunder-Blaze wants to merge 2 commits into
Open
feat(relay): add maxTotalEventsPerReq to cap aggregate events across filters#208Thunder-Blaze wants to merge 2 commits into
Thunder-Blaze wants to merge 2 commits into
Conversation
hoytech
reviewed
Apr 22, 2026
hoytech
left a comment
Owner
There was a problem hiding this comment.
Good idea, thanks! I wonder if we should put a default in, instead of unlimited? Can you maybe start a discussion in the TG channel about this? My instinct would be something like 2000 or so.
08a4650 to
72b138c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
maxFilterLimitcaps the events returned by each individual filter (default 500), but a REQ with many filters can returnmaxReqFilterSize * maxFilterLimitevents (e.g. 200 * 500 = 100,000). There's no aggregate cap.This adds
relay.maxTotalEventsPerReq(default 0 = unlimited). When set, the total events sent across all filters in a single REQ is capped. Once the limit is hit, remaining filters are skipped and a warning is logged. The client still receives a normal EOSE.Issue
rate limitssection)Testing
Custom tests