perf(events): skip redundant writer dup probe when caller pre-checked#227
Open
Thunder-Blaze wants to merge 1 commit into
Open
perf(events): skip redundant writer dup probe when caller pre-checked#227Thunder-Blaze wants to merge 1 commit into
Thunder-Blaze wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
WriterPipeline(used bystrfry import/sync/router) already probeslookupEventByIdunder a read-only txn right before opening itstxn_rwand callingwriteEvents(). The same probe then runs again insidewriteEventsfor every event. Consolidates to one probe on that path.Adds
bool preCheckedonEventToWrite. When set,writeEvents()skipslookupEventByIdbut still runs the unconditional intra-batch guard (ev.id() == evs[i-1].id()).WriterPipelinesets the flag right after its pre-filter.RelayIngester→RelayWriteris intentionally not changed: the ingester's ro-txn is a batch-start snapshot and with multiple ingester threads its probe can be stale by the time the writer processes the message; skipping the writer probe there would race and double-insert.